Comments on: Best Practices: compareTo consistent with equals http://blog.palantirtech.com/2007/09/02/compareto-consistent-with-equals/ Articles from the Engineering Group at Palantir Technologies Tue, 24 Jan 2012 09:51:18 +0000 hourly 1 http://wordpress.org/?v=3.2.1 By: Philippe http://blog.palantirtech.com/2007/09/02/compareto-consistent-with-equals/comment-page-1/#comment-91 Philippe Wed, 12 Sep 2007 08:05:01 +0000 http://blog.palantirtech.com/2007/07/28/compareto-consistent-with-equals/#comment-91 Nice tip. I have three little remarks: Lines 10-11: "instanceof" returns false if the object "o" is null, so the first line is useless. Line 12: the variable "d" should be "o" Line 10: you can optimize (a bit) the method by adding this code "if (this == o) return true;" on the first line. It will return true if you check an object against itself. Nice tip. I have three little remarks:

Lines 10-11: “instanceof” returns false if the object “o” is null, so the first line is useless.

Line 12: the variable “d” should be “o”

Line 10: you can optimize (a bit) the method by adding this code
“if (this == o) return true;” on the first line. It will return true if you check an object against itself.

]]> By: Jeff http://blog.palantirtech.com/2007/09/02/compareto-consistent-with-equals/comment-page-1/#comment-87 Jeff Tue, 04 Sep 2007 20:24:15 +0000 http://blog.palantirtech.com/2007/07/28/compareto-consistent-with-equals/#comment-87 Don't forget that the same advice applies to hashCode as well. Don’t forget that the same advice applies to hashCode as well.

]]>